[SDK] Add tests for chain utils #5280

kien-ngo · 2024-11-04T15:41:33Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing the CUSTOM_CHAIN_MAP and convertLegacyChain functionalities, making them exportable for testing. It also adds new test cases to validate chain properties and conversions.

Detailed summary

Changed CUSTOM_CHAIN_MAP to be exported for testing.
Exported convertLegacyChain function for internal use.
Added a legacyChain object representing Ethereum Mainnet.
Introduced multiple test cases for chain properties and conversions.
Verified caching of chains using CUSTOM_CHAIN_MAP.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-11-04T15:41:37Z

⚠️ No Changeset found

Latest commit: c63fefd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-11-04T15:41:37Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

vercel · 2024-11-04T15:41:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 1:55am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 1:55am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 1:55am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 1:55am

kien-ngo · 2024-11-04T15:41:49Z

[SDK] Add tests for chain utils #5280 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

github-actions · 2024-11-04T15:44:51Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	43 KB (0%)	860 ms (0%)	621 ms (+56.88% 🔺)	1.5 s
thirdweb (cjs)	102.98 KB (-0.04% 🔽)	2.1 s (-0.04% 🔽)	1.1 s (+15.25% 🔺)	3.1 s
thirdweb (minimal + tree-shaking)	4.85 KB (0%)	97 ms (0%)	106 ms (+437.66% 🔺)	203 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	75 ms (+961.71% 🔺)	85 ms
thirdweb/react (minimal + tree-shaking)	17.57 KB (0%)	352 ms (0%)	260 ms (+398.97% 🔺)	611 ms

gregfromstl

Looks good, tests are just failing

gregfromstl · 2024-11-04T20:05:35Z

Merge activity

Nov 4, 3:05 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 4, 8:38 PM EST: A user added this pull request to the Graphite merge queue.
Nov 4, 8:55 PM EST: A user merged this pull request with the Graphite merge queue.

codecov · 2024-11-05T01:22:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.55%. Comparing base (f98059c) to head (c63fefd).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5280      +/-   ##
==========================================
+ Coverage   45.47%   45.55%   +0.08%     
==========================================
  Files        1067     1068       +1     
  Lines       55486    55514      +28     
  Branches     4013     4029      +16     
==========================================
+ Hits        25230    25292      +62     
+ Misses      29565    29532      -33     
+ Partials      691      690       -1

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from f98059c
packages	`40.65% <100.00%> (+0.11%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
packages/thirdweb/src/chains/utils.ts	`84.34% <100.00%> (+26.08%)`	⬆️

... and 2 files with indirect coverage changes

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR enhances the `CUSTOM_CHAIN_MAP` and `convertLegacyChain` function to be exported for testing purposes. It also adds new tests for chain handling, including legacy chain conversion and caching functionality. ### Detailed summary - Exported `CUSTOM_CHAIN_MAP` for testing. - Exported `convertLegacyChain` function. - Added a `legacyChain` object for testing. - Created tests for: - `getChainSymbol` - `getChainDecimals` - `getChainNativeCurrencyName` - `convertLegacyChain` - `defineChain` with a legacy chain. - Caching functionality with `cacheChains`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

kien-ngo marked this pull request as ready for review November 4, 2024 15:41

kien-ngo requested review from gregfromstl, jnsdls and joaquim-verges as code owners November 4, 2024 15:41

github-actions bot added the packages label Nov 4, 2024

vercel bot deployed to Preview – wallet-ui November 4, 2024 15:44 View deployment

vercel bot deployed to Preview – thirdweb_playground November 4, 2024 15:44 View deployment

vercel bot deployed to Preview – thirdweb-www November 4, 2024 15:52 View deployment

vercel bot deployed to Preview – docs-v2 November 4, 2024 15:53 View deployment

gregfromstl approved these changes Nov 4, 2024

View reviewed changes

gregfromstl assigned kien-ngo Nov 4, 2024

gregfromstl enabled auto-merge (squash) November 4, 2024 20:02

gregfromstl disabled auto-merge November 4, 2024 20:03

gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 4, 2024

kien-ngo force-pushed the kien/tests-for-chains branch from 2f5b66f to d014c1b Compare November 5, 2024 01:16

vercel bot deployed to Preview – thirdweb_playground November 5, 2024 01:26 View deployment

vercel bot deployed to Preview – wallet-ui November 5, 2024 01:28 View deployment

vercel bot deployed to Preview – thirdweb-www November 5, 2024 01:37 View deployment

vercel bot deployed to Preview – docs-v2 November 5, 2024 01:38 View deployment

gregfromstl force-pushed the kien/tests-for-chains branch from d014c1b to c63fefd Compare November 5, 2024 01:38

vercel bot deployed to Preview – thirdweb_playground November 5, 2024 01:44 View deployment

vercel bot deployed to Preview – wallet-ui November 5, 2024 01:45 View deployment

vercel bot deployed to Preview – docs-v2 November 5, 2024 01:53 View deployment

vercel bot deployed to Preview – thirdweb-www November 5, 2024 01:55 View deployment

graphite-app bot merged commit c63fefd into main Nov 5, 2024
31 of 32 checks passed

graphite-app bot deleted the kien/tests-for-chains branch November 5, 2024 01:55

vercel bot deployed to Production – wallet-ui November 5, 2024 02:07 View deployment

vercel bot deployed to Production – docs-v2 November 5, 2024 02:07 View deployment

vercel bot deployed to Production – thirdweb-www November 5, 2024 02:07 View deployment

vercel bot deployed to Production – thirdweb_playground November 5, 2024 02:08 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Add tests for chain utils #5280

[SDK] Add tests for chain utils #5280

Uh oh!

kien-ngo commented Nov 4, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Nov 4, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 4, 2024

Uh oh!

vercel bot commented Nov 4, 2024 •

edited

Loading

Uh oh!

kien-ngo commented Nov 4, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 4, 2024 •

edited

Loading

Uh oh!

gregfromstl left a comment

Uh oh!

gregfromstl commented Nov 4, 2024 •

edited by graphite-app bot

Loading

Uh oh!

codecov bot commented Nov 5, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[SDK] Add tests for chain utils #5280

[SDK] Add tests for chain utils #5280

Uh oh!

Conversation

kien-ngo commented Nov 4, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Nov 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

vercel bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kien-ngo commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

gregfromstl left a comment

Choose a reason for hiding this comment

Uh oh!

gregfromstl commented Nov 4, 2024 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

codecov bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kien-ngo commented Nov 4, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Nov 4, 2024 •

edited

Loading

vercel bot commented Nov 4, 2024 •

edited

Loading

kien-ngo commented Nov 4, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024 •

edited

Loading

gregfromstl commented Nov 4, 2024 •

edited by graphite-app bot

Loading

codecov bot commented Nov 5, 2024 •

edited

Loading